Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested try/except on _load_jupyter_server_extension discovery #213

Merged

Conversation

echarles
Copy link
Member

@echarles echarles commented Apr 27, 2020

This is a follow-up of #212 to ensure the try/except is correctly nested and the load_jupyter_server_extension is only called if it exists.

Calling load_jupyter_server_extension is now outside of any try/except otherwise the server will be started even if it should not (e.g. load_jupyter_server_extension throwing a AttributeError)

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Thanks, @echarles. This nesting looks right.

@Zsailer Zsailer merged commit 2f02e93 into jupyter-server:master Apr 27, 2020
@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
…ning-message2

Nested try/except on _load_jupyter_server_extension discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants